-
Notifications
You must be signed in to change notification settings - Fork 13
Add support for JetBrainsRuntime #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zaro Thanks for your contribution! ❤️
|
@zaro Unfortunately I had to revert this change because the JetBrains provider seems to be hanging for unknown reasons: https://github.com/joschi/java-metadata/actions/runs/12759006080/job/35562033821 Maybe you can take a look at some other time. |
|
@joschi Sure, will take a look and try to fix. |
|
IMO there is nothing wrong with the script , it's simply the number of files that need to be downloaded and processed. I must admit that during my local testing I limited the number of releases processed, because the full run will take many hours on my internet connection. Now here are the details: I see two ways around that:
@joschi What do you think? Which one is preferable ? |
I think this would be preferable, if you can spend the time running the initial download. |
|
@zaro It also looks like the architecture, OS, Java version, and version attributes are not properly detected as well as the file type. Example: You can run your script locally via |
This approach is parsing the body of the Github releases for JetBrainsRuntime, which contains a easily parsable markdown table.
Fixes #41